Skip to content

Originator with long text should be clipped #4881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
compulim wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Originator with long text should be clipped #4881

compulim wants to merge 6 commits into from

Conversation

@compulim
Copy link
Contributor

@compulim compulim commented Sep 27, 2023 •
edited
Loading

Fixes #4880.

Changelog Entry

Fixed

  • Fixes #4880. Originator with long text should be clipped with ellipsis, by @compulim, in PR #4881

Description

Originator with long text should be clipped with ellipsis.

image

Specific Changes

  • Updated stylesheet of activity status originator
  • Removed stylesheet of SlottedActivityStatus because we never use it
  • Added tooltip to originator link
  • Fixed typo of SelfActivityStatus
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review September 27, 2023 22:46
@compulim compulim added this to the imminent milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@beyackle2 beyackle2 Awaiting requested review from beyackle2 beyackle2 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

imminent

Development

Successfully merging this pull request may close these issues.

Originator with long text should be clipped with ellipsis

2 participants

@compulim